Skip to content

block: revert avoid acquiring cpu hotplug lock in group_cpus_evenly#599

Closed
blktests-ci[bot] wants to merge 3 commits intolinus-master_basefrom
series/1058417=>linus-master
Closed

block: revert avoid acquiring cpu hotplug lock in group_cpus_evenly#599
blktests-ci[bot] wants to merge 3 commits intolinus-master_basefrom
series/1058417=>linus-master

Conversation

@blktests-ci
Copy link
Copy Markdown

@blktests-ci blktests-ci Bot commented Feb 26, 2026

Pull request for series with
subject: block: revert avoid acquiring cpu hotplug lock in group_cpus_evenly
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1058417

@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Feb 26, 2026

Upstream branch: 7dff99b
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Feb 27, 2026

Upstream branch: a75cb86
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from 572f4e9 to 7d4e359 Compare February 27, 2026 16:37
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 14f6b99 to 856dc37 Compare February 27, 2026 22:07
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Feb 27, 2026

Upstream branch: 4d349ee
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from 7d4e359 to 83ef6df Compare February 27, 2026 22:16
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 856dc37 to 40967f0 Compare March 2, 2026 09:22
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 2, 2026

Upstream branch: 11439c4
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from 83ef6df to ae31a92 Compare March 2, 2026 09:31
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 40967f0 to d4e9bad Compare March 2, 2026 23:54
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 3, 2026

Upstream branch: af4e9ef
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from ae31a92 to 4fc2a4a Compare March 3, 2026 00:03
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch 2 times, most recently from ecd10e2 to d0e1bed Compare March 4, 2026 07:45
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 4, 2026

Upstream branch: af4e9ef
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from 4fc2a4a to 6eecec1 Compare March 4, 2026 08:01
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from d0e1bed to 6b51c57 Compare March 4, 2026 09:34
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 4, 2026

Upstream branch: 0031c06
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from 6eecec1 to a1181d5 Compare March 4, 2026 09:44
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 6b51c57 to 78036b2 Compare March 4, 2026 19:57
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 4, 2026

Upstream branch: ecc64d2
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from a1181d5 to d001c7d Compare March 4, 2026 20:07
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 78036b2 to bbb3394 Compare March 5, 2026 12:20
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 5, 2026

Upstream branch: c107785
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from d001c7d to 1caa45d Compare March 5, 2026 12:29
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 868d59a to 1f531be Compare March 18, 2026 11:51
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 18, 2026

Upstream branch: a989fde
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from e59ac72 to 4eaac6a Compare March 18, 2026 12:06
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 1f531be to 3f39b19 Compare March 22, 2026 09:19
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 22, 2026

Upstream branch: 113ae7b
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from 4eaac6a to 0f457d5 Compare March 22, 2026 09:35
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 3f39b19 to 0d26589 Compare March 23, 2026 09:35
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 23, 2026

Upstream branch: c369299
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from 0f457d5 to 5123678 Compare March 23, 2026 09:51
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 0d26589 to 359a150 Compare March 24, 2026 20:10
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 24, 2026

Upstream branch: e3c33bc
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from 5123678 to 0f1a795 Compare March 24, 2026 20:44
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from 359a150 to a5e341d Compare March 25, 2026 13:21
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 25, 2026

Upstream branch: bbeb83d
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from 0f1a795 to 7605ff6 Compare March 25, 2026 13:57
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from a5e341d to c13734b Compare March 27, 2026 12:29
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 27, 2026

Upstream branch: 46b5132
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from 7605ff6 to 22c696c Compare March 27, 2026 12:49
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from c13734b to ef67188 Compare March 27, 2026 23:13
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 27, 2026

Upstream branch: 7df48e3
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from 22c696c to 459a89e Compare March 27, 2026 23:34
@blktests-ci blktests-ci Bot force-pushed the linus-master_base branch from ef67188 to 4439509 Compare March 28, 2026 06:36
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 28, 2026

Upstream branch: be762d8
series: https://patchwork.kernel.org/project/linux-block/list/?series=1058417
version: 1

igaw added 3 commits March 28, 2026 16:00
When the ctrl is not in LIVE state, a hardware queue can be in the
INACTIVE state due to CPU hotplug offlining operations. In this case,
the driver will freeze and quiesce the request queue and doesn't expect
new request entering via queue_rq. Though a request will fail eventually,
though shortcut it and fail it earlier.

Check if a request is targeted for an inactive hardware queue and use
nvme_failover_req and hand it back to the block layer.

Signed-off-by: Daniel Wagner <wagi@kernel.org>
The CPU hotplug offline handler in the block layer checks for any
in-flight requests on a CPU going offline. It prevents the CPU hotplug
state engine from progressing as long as there are pending requests.

This is done by checking for any allocated requests on the hardware
context that is going offline. The driver is responsible for completing
all in-flight requests.

However, the driver might be performing error recovery simultaneously.
Therefore, the request queue might be in a frozen or quiesced state. In
this case, requests may not make progress (see
blk_mq_sched_dispatch_requests for an example).

Introduce an explicit handshake protocol between the driver and the
block layer. This allows the driver to signal when it is safe to ignore
any remaining pending requests.

Signed-off-by: Daniel Wagner <wagi@kernel.org>
…pus_evenly"

This reverts commit 0263f92.

The reason the lock was removed was that the nvme-pci driver reset
handler attempted to acquire the CPU read lock during CPU hotplug
offlining (holds the CPU write lock). Consequently, the block layer
offline notifier callback could not progress because in-flight requests
were detected.

Since then, in-flight detection has been improved, and the nvme-pci
driver now explicitly updates the hctx state when it is safe to ignore
detected in-flight requests. As a result, it's possible to reintroduce
the CPU read lock in group_cpus_evenly.

Signed-off-by: Daniel Wagner <wagi@kernel.org>
@blktests-ci blktests-ci Bot force-pushed the series/1058417=>linus-master branch from 459a89e to 00ffff0 Compare March 28, 2026 07:00
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci Bot commented Mar 28, 2026

At least one diff in series https://patchwork.kernel.org/project/linux-block/list/?series=1058417 irrelevant now for [{'archived': False, 'project': 241}] search patterns

@blktests-ci blktests-ci Bot closed this Mar 28, 2026
@blktests-ci blktests-ci Bot deleted the series/1058417=>linus-master branch March 30, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant